Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5401 dcmdoc #5620

Merged
merged 2 commits into from
Mar 12, 2019
Merged

5401 dcmdoc #5620

merged 2 commits into from
Mar 12, 2019

Conversation

pameyer
Copy link
Contributor

@pameyer pameyer commented Mar 11, 2019

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.269% when pulling 2f14c44 on 5401-dcmdoc into 6ca381d on develop.

@@ -16,7 +16,7 @@ Data Capture Module (DCM) is an experimental component that allows users to uplo
Install a DCM
~~~~~~~~~~~~~

Installation instructions can be found at https://github.com/sbgrid/data-capture-module . Note that a shared filesystem (posix or AWS S3) between Dataverse and your DCM is required. You cannot use a DCM with Swift at this point in time.
Installation instructions can be found at https://github.com/sbgrid/data-capture-module/blob/master/doc/installation.md. Note that shared storage (posix or AWS S3) between Dataverse and your DCM is required. You cannot use a DCM with Swift at this point in time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this effort, should we move "big data support" from the dev guide to some other guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like it's out of scope for this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks.

@kcondon kcondon merged commit e40fdc3 into develop Mar 12, 2019
@kcondon kcondon deleted the 5401-dcmdoc branch March 12, 2019 15:45
@pdurbin pdurbin added this to the 4.12 milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants